github.com/moarvm/moarvm | IRC logs at colabti.org/irclogger/irclogger_logs/moarvm
Set by AlexDaniel on 12 June 2018.
Geth_ MoarVM: 41708648cf | (Stefan Seifert)++ | src/core/interp.c
Revert "Workaround for segfault somehow caused by NativeCall callbacks"

This reverts commit 7ab23a1b89d4a191fc0f9547ba2a0b6866ce3d95 as a proper fix has been found.
11:59
MoarVM: ae66545c7b | (Stefan Seifert)++ | 2 files
Fix segfaults after callbacks originating in JIT compiled calls to native code

Before running a non-toplevel frame, we need to make sure, the caller's frame has a valid return_address. While MVM_nativecall_invoke_jit and MVM_nativecall_invoke did so, the JIT implementation of calls to JIT compiled native functions did not. This could lead to segfaults when native code called from JIT compiled code ran callbacks which then tried to return to the NULL address.
Fix by initializing tc->cur_frame->return_address in the callback_handler, so it doesn't matter how we ended up there.
nine sena_kun: this is the real fix for the release ^^^ 12:02
tadzik sena_kun: pretty much all of my stuff is abandoned :) 13:14
tellable6 2019-12-21T14:12:40Z #raku-dev <patrickb> tadzik Thanks for the reply and heads up!
2019-12-21T14:12:53Z #raku-dev <patrickb> tadzik I'll go forward in that direction then.
2019-12-25T22:54:06Z #moarvm <sena_kun> tadzik is github.com/tadzik/Module-Toolkit abandoned?
sena_kun o/ 19:49
tadzik \o 19:50
sena_kun: in case you missed it: pretty much all of my stuff is abandoned :)
sena_kun so I checked, well, everything from our ecosystem. I think, a moarvm release can be shipped from github.com/MoarVM/MoarVM/commit/7a...6866ce3d95 (as I checked this one)
tadzik: yeah, needed to make sure. :) 19:51
I am not sure about including github.com/MoarVM/MoarVM/commit/ae...076d38c7a2 and don't think I'll test another 400 modules from our ecosystem by hands, at least not this release. :S 19:52
but if it looks sane to core devs and passes tests, I think it is pretty much safe anyway
(does it count as a green light?) 19:53
lizmat sena_kun: if nine is ok with it, I'm ok with it :-) 19:54
sena_kun hopes we'll be able to do the release this month 19:55
lizmat too :-) 20:09