github.com/moarvm/moarvm | IRC logs at colabti.org/irclogger/irclogger_logs/moarvm
Set by AlexDaniel on 12 June 2018.
01:25 squashable6 left 01:26 linkable6 left 01:27 linkable6 joined, Altreus left, evalable6 left 01:28 Altreus joined 02:05 squashable6 joined 02:06 evalable6 joined 03:59 evalable6 left, linkable6 left 04:01 evalable6 joined 04:02 linkable6 joined 04:36 leont left 06:01 sortiz left 07:38 brrt joined 07:54 domidumont joined 08:18 MasterDuke joined 08:20 Geth joined 08:25 squashable6 left 08:27 squashable6 joined 08:47 zakharyas joined 09:06 sena_kun left 09:07 sena_kun joined, sena_kun left 09:09 sena_kun joined 09:14 leont joined
MasterDuke it's interesting, on my remove_candidates branch heaptrack shows 20m more calls to allocation functions and 4.7m more temporary allocations, but peak heap and rss are almost identical 09:26
so just a lot more churn, but not more memory being used in total 09:27
09:44 brrt left 09:49 brrt joined
MasterDuke oh, valgrind (and heaptrack) show a leak on my branch, haven't figured out what's leaking yet. gist.github.com/MasterDuke17/42853...171b92ff5b 11:41
12:47 evalable6 left, linkable6 left 12:48 cog_ joined, evalable6 joined 12:50 linkable6 joined 12:51 cog left 12:53 zakharyas left
MasterDuke ok, removing isn't the problem, it leaks even if no candidates are ever removed 13:07
well, i added what i believe was a missing free of `cands_and_arg_guards->spesh_candidates` in MVMStaticFrameSpesh.c's gc_free, but still the same leak 13:19
13:59 brrt left, brrt` joined 14:35 brrt` is now known as brrt
brrt good * 14:43
14:47 MasterDuke left 14:48 MasterDuke joined 15:04 MasterDuke left 15:05 MasterDuke joined
nwc10 good *, brrt 15:05
it is sunny outside. I'm going back outside
(just popping inside to collect some inspiration from the beer fridge) 15:06
it is sunny "this week"
15:09 brrt left
MasterDuke it is the remove_candidates branch that introduces the leak, it's not there on master 15:26
15:47 brrt joined 16:31 vrurg left 16:37 vrurg joined 17:16 zakharyas joined 18:34 domidumont left 18:43 Geth left 18:50 brrt left 19:05 zakharyas left 19:52 brrt joined 20:38 Kaeipi joined, BinGOs left, moon-child left, nine left 20:39 nwc10_ joined, rba left, samcv left, codesections left, bartolin joined, jnthn_ joined, codesections joined, samcv joined, earenndil joined, nine_ joined, mst_ joined, mst_ left, mst_ joined, ChanServ sets mode: +o mst_ 20:40 mst left, rba joined, nwc10 left, brrt left, patrickbkr[m] left, jnthn left, sena_kun left, bingos joined, Kaiepi left 20:42 codesections left 20:43 camelia left, mst_ is now known as mst 20:44 camelia joined 20:45 codesections joined 20:52 zakharyas joined 21:16 patrickbkr[m] joined 21:37 zakharyas left 22:06 earenndil is now known as moon-child