|
01:33
MasterDuke joined
|
|||
| MasterDuke | m: use nqp; nqp::strtocodes("3.9999999999", 1, my int32 @a); dd @a; nqp::splice(@a, nqp::list_i(9), 1, 1); dd @a | 01:34 | |
| evalable6 | int32 = array[int32].new(51, 46, 57, 57, 57, 57, 57, 57, 57, 57, 57, 57) int32 = array[int32].new(51, 9, 57, 57, 57, 57, 57, 57, 57, 57, 57, 57) |
||
| MasterDuke | m: use nqp; nqp::strtocodes("3.9999999999", 1, my int32 @a); dd @a; nqp::splice(@a, nqp::list(9), 1, 1); dd @a | ||
| evalable6 | int32 = array[int32].new(51, 46, 57, 57, 57, 57, 57, 57, 57, 57, 57, 57) int32 = array[int32].new(51, -692688496, 57, 57, 57, 57, 57, 57, 57, 57, 57, 57) |
||
| MasterDuke | m: use nqp; nqp::strtocodes("3.9999999999", 1, my int32 @a); dd @a; nqp::splice(@a, nqp::list_i, 1, 1); dd @a | 01:35 | |
| evalable6 | (signal SIGSEGV) int32 = array[int32].new(51, 46, 57, 57, 57, 57, 57, 57, 57, 57, 57, 57) | ||
| MasterDuke | at first i thought it was trying to splice in the wrong typed list that was the problem, but it appears to be the emptiness that triggers it | 01:36 | |
| m: use nqp; my int32 @a = 1,2,3,4,5,6,7,8,9,10,11; dd @a; nqp::splice(@a, nqp::list, 1, 1); dd @a | |||
| evalable6 | int32 = array[int32].new(1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11) int32 = array[int32].new(1, 3, 4, 5, 6, 7, 8, 9, 10, 11) |
||
| MasterDuke | but not sure why the one created by strtocodes is a problem, and "normally" created ones aren't | 01:37 | |
| Geth | MoarVM: MasterDuke17++ created pull request #2006: Correctly populate dest array in nqp::strtocodes |
02:00 | |
|
02:10
MasterDuke left
10:21
sugarbeet left
10:22
sugarbeet joined
10:36
librasteve_ left
14:38
kjp left,
kjp joined
19:28
ShimmerFairy left
19:30
ShimmerFairy joined
19:53
ShimmerFairy left
|
|||
| Geth | MoarVM/main: 333554c4b1 | (Daniel Green)++ | src/strings/normalize.c Correctly populate dest array in nqp::strtocodes The array populated by nqp::strtocodes (i.e., MVM_unicode_string_to_codepoints), wasn't getting its `ssize` set. Some uses of it would be ok, but attempting to resize it could go bady. |
21:53 | |
| MoarVM/main: dcd0d116d0 | MasterDuke17++ (committed using GitHub Web editor) | src/strings/normalize.c Merge pull request #2006 from MasterDuke17/correctly_create_array_in_strtocodes Correctly populate dest array in nqp::strtocodes |
|||
| [Coke] | merging it before getting concensus means you've decided it's going in the release. :) | 21:56 | |
|
22:07
ShimmerFairy joined
|
|||
| timo | it doesn't look wrong. i've been meaning to review it but didn't get the tuits | 22:07 | |
|
22:16
vrurg_ joined
22:20
vrurg left
|
|||