|
05:10
sibl joined
09:25
[r4] joined
09:30
[r4] left
09:31
[r4] joined
11:12
librasteve_ joined
11:17
sibl left
15:11
Z-raku joined
|
|||
| Z-raku | I need pull request advice for newbie (me). I noticed an incorrect link for take-rw at docs.raku.org/language/control#gather/take. I forked and updated the link on github. Is it OK to just submit the pull request? | 15:22 | |
| disbot2 | <librasteve> yeah - are you in the github web UI (that's how O do it)? | 15:26 | |
| Z-raku | Yes | ||
| disbot2 | <librasteve> when you make the PR - usually to the main 'theirid/main' from your branch 'yourid/my-change' ... you will see a reflection of this at the top of the PR page you have made --- pop in s a description and then submit | 15:29 | |
| <librasteve> (you can edit this - eg if you wanted to submit to an different branch) | |||
| Z-raku | thank you | ||
| disbot2 | <librasteve> yw | 15:30 | |
| <librasteve> on the top right, you can assign a reviewer - add me if you like | |||
| Z-raku | (y) | 15:31 | |
| disbot2 | <librasteve> (I found working with Raku was a great way to get from Github newbie to a working knowledge of PRs and so on) | ||
| Z-raku | I submitted the PR. I see "Reviewers" on the top right of the PR, but no way to "assign a reviewer". | 15:39 | |
| I'm looking forward to getting working knowledge of both version mgmt and Raku. :-) | 15:44 | ||
| disbot2 | <librasteve> just click on the word Reviewers | 15:46 | |
| <librasteve> then you get a search box | |||
| Z-raku | No link or action on Reviewers for me. It may be because I just created the account. | 15:49 | |
| Also found missing header in doc/CONTRIBUTING.md and submitted PR for that as well. Thanks for the help librasteve_ | 15:58 | ||
|
16:47
Z-raku left,
Z-raku joined
16:49
Z-raku left,
human-blip left
16:51
human-blip joined
|
|||
| disbot2 | <librasteve> oh - looks like assigning reviewers is a privilege of admins - soz | 17:14 | |
| <librasteve> btw there is plenty of stuff to be done on the docs side ... check out the #raku-doc channel if you would like to ask for guidance or ideas | 17:15 | ||
| [Coke] | Could always use more help in docs. | 17:43 | |
| I rejected one of your PRs but used it as insipiration to clean that up a different way | |||
| Thanks for the poke! | 17:44 | ||
|
20:45
[r4] left
|
|||