|
00:23
Kaeipi joined
00:24
Kaiepi left
|
|||
| Geth | ¦ problem-solving: ToddAndMargo assigned to jnthn Issue uint's confused with int's github.com/Raku/problem-solving/issues/154 | 00:32 | |
|
00:45
sena_kun left
01:01
sena_kun joined
01:44
lucs left
02:27
MasterDuke left
02:45
sena_kun left
02:59
sena_kun joined
03:21
lucasb left
04:44
sena_kun left
04:59
sena_kun joined
05:27
bisectable6 left
05:28
linkable6 joined,
bisectable6 joined
|
|||
| AlexDaniel | #154 | 05:45 | |
| PS#154 | |||
| linkable6 | PS#154 [open]: github.com/Raku/problem-solving/issues/154 [language] uint's confused with int's | ||
|
06:45
sena_kun left
06:59
sena_kun joined
08:46
sena_kun left
08:59
sena_kun joined
09:15
bisectable6 left,
evalable6 left,
tellable6 left,
bisectable6 joined
09:16
tellable6 joined
09:17
evalable6 joined
09:45
domidumont joined,
MasterDuke joined
10:45
sena_kun left
10:59
sena_kun joined
|
|||
| sena_kun | ping rba | 11:16 | |
| Geth | rakudo: 392af08b0b | (Elizabeth Mattijsen)++ | src/core.c/Proc.pm6 Save one Scalar allocation for each run/shell/QX |
11:19 | |
| lizmat | sena_kun: can I be of assistance wrt the release ? | 11:20 | |
|
11:43
linkable6 left
11:44
linkable6 joined
12:45
sena_kun left
12:47
Kaiepi joined
12:49
Kaeipi left
12:50
Kaiepi left,
Kaiepi joined
|
|||
| Geth | rakudo: 3326669414 | (Elizabeth Mattijsen)++ | src/core.c/Proc.pm6 Make Proc.exitcode default Nil This saves one action in the BUILDPLAN for Proc, and it makes checking for absence of an exitcode faster, and it more appriopriately expresses the absence of an exitcode should the exitcode accessor be used prematurely. |
12:52 | |
|
12:59
sena_kun joined
13:02
lucasb joined
14:36
lucs joined
14:46
sena_kun left
14:59
domidumont left
15:00
sena_kun joined
15:16
titsuki joined
|
|||
| sena_kun | sadly, 6.c errata is much more broken than it was previously. I wonder if all those regressions appeared since 2019.11, this doesn't seem too super-likely to me somehow. | 15:46 | |
| github.com/rakudo/rakudo/issues/3443 | |||
|
16:11
epony left
|
|||
| dogbert11 | .seen lizmat | 16:20 | |
| tellable6 | dogbert11, I saw lizmat 2020-01-26T12:35:51Z in #raku: <lizmat> the first statement does *not* return, it merely creates an empty list that is sunk, which causes the warning | ||
| dogbert11 | .ask lizmat should I make a PR for github.com/perl6/nqp/issues/559 ? | 16:22 | |
| tellable6 | dogbert11, I'll pass your message to lizmat | ||
|
16:46
sena_kun left
17:00
sena_kun joined
17:02
titsuki left
17:31
domidumont joined
|
|||
| AlexDaniel | sena_kun: it does look “normal” to me | 17:46 | |
| that's about the regular amount you'd get per release | |||
| sena_kun | AlexDaniel: what do you mean? | 17:52 | |
| or, rather, what's the implications of this being "normal"? | 17:53 | ||
| no need to fix 'em? | |||
| AlexDaniel | sena_kun: need to figure out each case. Sometimes the tests are just obviously wrong so you can just fix them, other times you may need to revert the change in rakudo | 17:54 | |
| one quick way is to look at the commits affecting these files on master | 17:55 | ||
| for example t/spec/S32-num/base.t | |||
| github.com/perl6/roast/commits/mas...num/base.t | |||
| b3cd406ea2 | |||
| linkable6 | (2020-01-09) github.com/perl6/roast/commit/b3cd406ea2 Fix erroneous test | ||
| AlexDaniel | so in this case, yeah, the test was obviously wrong | ||
| so you can cherry-pick this into 6.c-errata and 6.d-errata | 17:56 | ||
| sena_kun | cherry-picking it into 6.c-errata? | ||
| AlexDaniel | you have access to do that now, I'm pretty sure | ||
| sena_kun | I see, thanks | ||
| sure, will do, working on examples repo right now | |||
| AlexDaniel | charset.t too github.com/perl6/roast/commit/34ab...a5909cba85 | 17:57 | |
| the test was just overly specific | 17:58 | ||
| sena_kun | .oO ( первый блин комам ) | 17:59 | |
| AlexDaniel | yes yes :) | ||
| lizmat: you can help | |||
| lizmat: figure out how 6d23891a3a7e and aa4994a7f6b can be applied to 6.c-errata | 18:00 | ||
| linkable6 | (2020-01-03) github.com/perl6/roast/commit/6d23891a3a Some s/perl/raku changes | ||
| (2020-01-03) github.com/perl6/roast/commit/aa4994a7f6 Call method .raku instead of .perl in tests | |||
| AlexDaniel | you definitely can't just change perl6→raku as that'll make all previous rakudo releases fail the test | 18:01 | |
| although… maybe that's alright? | |||
| not like any other fixed test is better | 18:02 | ||
| sena_kun does cherry-picking | 18:03 | ||
| lizmat is back from some cycling | 18:08 | ||
| tellable6 | 2020-01-26T16:22:14Z #raku-dev <dogbert11> lizmat should I make a PR for github.com/perl6/nqp/issues/559 ? | ||
| lizmat | .tell dogbert11 yes, a PR for 6d23891a3a7e github.com/perl6/nqp/issues/559 would be great! | 18:09 | |
| linkable6 | (2020-01-03) github.com/perl6/roast/commit/6d23891a3a Some s/perl/raku changes | ||
| tellable6 | lizmat, I'll pass your message to dogbert17 | ||
| lizmat | sena_kun AlexDaniel not sure what is expected of me | 18:10 | |
| Geth | roast/6.c-errata: f2f5460c5c | (Elizabeth Mattijsen)++ (committed by Altai-man) | S32-num/base.t Fix erroneous test Since github.com/rakudo/rakudo/commit/97e7cdbd54 this test would fail. Since the test involved *no* specific number of digits, any trailing 0 should be removed. The new implementation does that in this case, the old implementation of Rational.base did not. |
18:13 | |
| roast/6.d-errata: 91928e0550 | (Elizabeth Mattijsen)++ (committed by Altai-man) | S32-num/base.t Fix erroneous test Since github.com/rakudo/rakudo/commit/97e7cdbd54 this test would fail. Since the test involved *no* specific number of digits, any trailing 0 should be removed. The new implementation does that in this case, the old implementation of Rational.base did not. |
|||
| roast/6.c-errata: 37d944a50c | (Elizabeth Mattijsen)++ (committed by Altai-man) | 2 files Make tests less language name specific |
18:15 | ||
| roast/6.d-errata: 2a90b8dfab | (Elizabeth Mattijsen)++ (committed by Altai-man) | 2 files Make tests less language name specific |
18:16 | ||
| sena_kun | lizmat: can you look what's wrong with `t/spec/S03-junctions/misc.t` on 6.c-errata branch? I understand it is related to .perl/.raku rename, but github.com/perl6/roast/commit/6d23...944f2fff0a claims this test should pass with any case. are we safe with cherry-picking this commit, isn't it a stone of our backward compatibility? | 18:20 | |
| Geth | roast/6.c-errata: f283311163 | (Elizabeth Mattijsen)++ (committed by Altai-man) | S17-supply/elems.t Remove silly test .elems on type objects generally gives "1", so why not here? |
18:22 | |
| roast/6.c-errata: ff2fb81dbe | (Elizabeth Mattijsen)++ (committed by Altai-man) | S17-supply/unique.t Remove silly test .unique on type objects generally gives a Seq with that type object, so why not here? |
|||
| roast/6.c-errata: a4f4cce7c3 | (Elizabeth Mattijsen)++ (committed by Altai-man) | S17-supply/squish.t You *can* run .squish on a Supply type object |
|||
| roast/6.d-errata: 50450b7942 | (Elizabeth Mattijsen)++ (committed by Altai-man) | S17-supply/elems.t Remove silly test .elems on type objects generally gives "1", so why not here? |
18:23 | ||
| roast/6.d-errata: d50f543a6a | (Elizabeth Mattijsen)++ (committed by Altai-man) | S17-supply/unique.t Remove silly test .unique on type objects generally gives a Seq with that type object, so why not here? |
|||
| roast/6.d-errata: 6da26e4032 | (Elizabeth Mattijsen)++ (committed by Altai-man) | S17-supply/squish.t You *can* run .squish on a Supply type object |
|||
| nqp: dogbert17++ created pull request #596: Fix for github.com/perl6/nqp/issues/559 |
18:26 | ||
| lizmat | sena_kun: am looking | 18:31 | |
| ah, I see the issue: the module provides a multi, but not proto | 18:32 | ||
| so the proto in Mu is what .raku sees, and decides the module doesn't have its own .perl | 18:33 | ||
| sena_kun | are we fixing it by roast fix or rakudo fix? | ||
| lizmat | it should probably be a rakudo fix | ||
| we could fix it in roast now, temporarily, if you don't want to cherry pick anything from master | 18:34 | ||
| I mean, the workaround is easy: don't use a multi, or provide your own proto | |||
| sena_kun | lizmat: I would better cherry pick for rakudo | 18:35 | |
| lizmat | ok, I'll try to come up with a rakudo fix then | ||
| sena_kun | I mean, roast is roast, but real people code can be broken, which is not so super probably, but still. | ||
| inb4: every fix can break someone's workflow | 18:36 | ||
| lizmat | hmmm... maybe it's an issue in Junction | 18:37 | |
| ah, no... I see the issue; Junction calls .raku, which then looks for .perl and decides it doesn't have one | 18:38 | ||
|
18:45
sena_kun left
|
|||
| lizmat | .tell sena_kun spec and stresstesting a fix | 18:53 | |
| tellable6 | lizmat, I'll pass your message to sena_kun | ||
|
18:58
sena_kun joined
|
|||
| Geth | rakudo: 87bc11710e | (Elizabeth Mattijsen)++ | src/core.c/Mu.pm6 Make determining .raku / .perl switch smarter Before this commit, if a module had a "multi method perl" in it, or a class (other than Mu) had one, calling .raku on that class would wrongly assume the class did *not* have a custom .perl method. This caused breakage in roast in the 6.c-errata branch. ... (8 more lines) |
19:09 | |
| lizmat | sena_kun AlexDaniel ^^^ | ||
| sena_kun | \o/ | ||
| tellable6 | 2020-01-26T18:53:23Z #raku-dev <lizmat> sena_kun spec and stresstesting a fix | ||
| Geth | rakudo/release-2020.01: f29849b1de | (Elizabeth Mattijsen)++ (committed by Altai-man) | src/core.c/Mu.pm6 Make determining .raku / .perl switch smarter Before this commit, if a module had a "multi method perl" in it, or a class (other than Mu) had one, calling .raku on that class would wrongly assume the class did *not* have a custom .perl method. This caused breakage in roast in the 6.c-errata branch. ... (8 more lines) |
19:11 | |
| sena_kun | lizmat: you are awesome! | 19:12 | |
| Geth | rakudo/release-2020.01: b76b784b09 | Altai-man++ (committed using GitHub Web editor) | docs/release_guide.pod Update release date Once again, hopefully this time for sure. |
19:15 | |
| AlexDaniel | lizmat: does it mean we can revert errata changes? | 19:24 | |
| sena_kun | AlexDaniel: the cherry-picks? no, they are fine, and the last broken was fixed in rakudo itself, I've already picked the commit to release branch | 19:25 | |
| lizmat | yeah, that last one was indeed a real issue | 19:26 | |
| AlexDaniel | ah nvm I misunderstood | ||
| lizmat++ sena_kun++ | 19:27 | ||
| sena_kun: I used to put the next day if it was late, it made me less nervous and my sleep schedule is ÷∞ed anyway | 19:35 | ||
| Geth | rakudo: 0c5a7075a9 | (Elizabeth Mattijsen)++ | src/core.c/Proc/Async.pm6 Streamline Proc::Async subclass attributes Should save 4 scalar containers per Proc::Async object + removes the sub BUILD |
19:38 | |
| sena_kun | AlexDaniel: my sleep schedule is from 9:30 to 1:40 stable, so not sure how the next day date would change my state. I am not really excited about the release process anyway, so no anticipation == no stress. :) | 19:41 | |
| AlexDaniel | right | ||
| Geth | rakudo: ca49dcbd57 | (Elizabeth Mattijsen)++ | src/core.c/Proc/Async.pm6 Bind a few variables rather than assigning As they are immutable anyway in their scope. |
19:55 | |
|
19:57
Kaiepi left,
Kaiepi joined
20:08
domidumont left
20:27
Kaiepi left,
Kaeipi joined
20:45
sena_kun left
20:46
Geth left
20:47
Geth joined
20:59
sena_kun joined
|
|||
| Geth | rakudo: 356bf3f762 | (Elizabeth Mattijsen)++ | src/core.c/Proc/Async.pm6 Rework Proc::Async.start internals - don't set up arrays when they are not needed - bind where we don't need assign - don't use named arguments for private methods - add some empty lines for readability - add some return constraints |
21:20 | |
| rakudo: 05916efa52 | (Elizabeth Mattijsen)++ | src/core.c/Proc/Async.pm6 Use faster nqp::istype instead of ~~ |
21:34 | ||
|
22:44
sena_kun left
|
|||
| Geth | roast/6.d-errata: 3a35e015ac | (Elizabeth Mattijsen)++ (committed by Altai-man) | packages/Advent/GrammarProfiler.pm6 Add reference to method "raku" to prevent infinilooping Not sure why this fixes it, but the module is playing some tricks with find_method, and so does the Mu.raku/perl logic, so maybe that is it. |
22:45 | |
|
22:47
titsuki joined
22:58
sena_kun joined
23:19
moritz left
|
|||