| Geth | doc/main: 0b54bd8707 | (Eric Forste)++ | doc/Language/exceptions.rakudoc using Failures: discussion and examples per issue 3978 - added a short discussion of using failures - added examples provided in 3978 by @niner (after cleaning them up a bit) |
10:33 | |
| doc/main: 0de977a9da | (Eric Forste)++ | doc/Language/exceptions.rakudoc fix some awkward wording |
|||
| doc/main: d7eb40ca02 | librasteve++ (committed using GitHub Web editor) | doc/Language/exceptions.rakudoc Merge pull request #4742 from arkiuat/issue-3978 using Failures: discussion and examples |
|||
| doc/main: 9d91660623 | (Eric Forste)++ | doc/Language/variables.rakudoc slightly demystified `temp` & `let` also relocated entry for `constant` to better reflect its current position in the summary table |
10:34 | ||
| doc/main: d59234c225 | (Eric Forste)++ | doc/Language/variables.rakudoc revert refs to "shadowing"; keep other changes |
|||
| doc/main: 3fc261e494 | librasteve++ (committed using GitHub Web editor) | doc/Language/variables.rakudoc Merge pull request #4744 from arkiuat/issue-4318 slightly demystified `temp` & `let` |
|||
| doc/main: 9f29f00e83 | (Eric Forste)++ | doc/Language/operators.rakudoc infix:<eqv>: explain user classes oft implement their own This is a minimal-effort attempt to close docs issue 3346 |
10:38 | ||
| doc/main: 69edb9c67a | librasteve++ (committed using GitHub Web editor) | doc/Language/operators.rakudoc Merge pull request #4747 from arkiuat/issue-3346 infix:<eqv>: explain user classes oft implement their own |
|||
| disbot8 | <librasteve> @arkiuat - I have approved and merged 3/4 of your PRs - thanks! the remaining one is approved, but still marked as Draft so I did not merge | 10:39 | |
| <librasteve> happy for you to merge if you have the powers | |||
| tbrowder | librasteve_: do you see any reason for me *not* to submit the code i showed earlier as a *draft pr*? its test on my server is freezing on the version test for some unknown reason. the syntax checks are passing. | 12:17 | |
|
13:59
wayland left,
wayland joined
|
|||
| [Coke] | submit it | 14:15 | |
| tbrowder | thnx | 14:16 | |
| any idea what may cause the hangup? | |||
| i do have a ton of untracked files in the repo | 14:20 | ||
| [Coke] | usually that fails very quickly if it's going to fail. it's just making sure you are running the latest release. | 14:26 | |
| Geth | doc: tbrowder++ created pull request #4748: Proposed solution for doc issue #4740 |
14:33 | |
| tbrowder | ok, submitted the pr, test is failing on Raku github. how should i fix it? on the Raku PR side? or my source on my PC, or my source on Github? | 14:44 | |
| [Coke] | tbrowder: note that the PR failed its tests (you can see which tests so you can test them locally if you want.) I added a comment for how to fix the more complicated one. | 14:48 | |
| tbrowder: you fix it the branch you're basing the PR on - that commit will be automatically added to the PR | 14:49 | ||
| you can't fix it "just on the PR". | 14:50 | ||
| And doing the working "on your PC" - I mean, that's where you'll probably do the coding, yes, but you have to commit and push somewhere, and that somewhere is your branch tbrowder:tb-exit-ok | 14:51 | ||
| (because you submitted the PR based on a fork, it doesn't exist as a branch anywhere in raku/doc) | 14:53 | ||
| (and the content seems fine, btw.) | 15:06 | ||
| Why not fix whitespace first in one commit, push it, and you can see what happens at the PR side? | 15:07 | ||
| still have trailing whitespace, it seems, and now the failure is that "exits-ok" doesn't exist... which makes sense, since in the released version, it's "exit-ok" - we don't test the examples with rakudo HEAD | 15:23 | ||
| I would add a note that "exits-ok" is only available as of 2026.01 | |||
| and then we can ignore the example failure until then. | 15:24 | ||
| Geth | doc/main: fa87c4f869 | (Eric Forste)++ | doc/Language/using-modules/code.rakudoc clarifying entry for `require` per issue 4273 |
||
| doc/main: 9e5983d8b8 | (Eric Forste)++ (committed using GitHub Web editor) | doc/Language/using-modules/code.rakudoc clarifying entry for `require` per issue 4273 |
|||
|
15:33
arkiuat joined
18:05
arkiuat left
18:13
arkiuat joined
18:17
arkiuat left
18:21
arkiuat joined
|
|||
| Geth | doc: arkiuat self-assigned "Regex and interpolation is a bit confusing" github.com/Raku/doc/issues/2230 arkiuat self-unassigned language/regexes: Rewrite "Regex interpolation" section github.com/Raku/doc/issues/2230 |
18:42 | |
| tbrowder | so then then the best way to do any new doc fix is to (1) fork the github raku main onto my PC, with the Raku github repo being my origin. and (2) do not fork iinto my own github repo from Raku github repo. Correct? | 20:15 | |
| arkiuat | tbrowder, you can do it that way if you make a separate branch for each issue, sure | 20:28 | |
| I've found it easier to keep my on-github repo synced to the main Raku-docs repo, and use that as my upstream origin. That isolates my local desktop repo from the main repo and gives any mistakes I make less of a chance of affecting the main repo. | 20:29 | ||
| That does mean that when I make major doc fix, I have to update both my on-github fork and my desktop fork, make a new branch on my desktop fork and modify it, push that branch up to the my github fork, and then go to github to submit that from my github fork as a new PR. | 20:30 | ||
| That may be extra work, but it makes me feel safer. When I want to make a minor fix, I just use the web editor, although I should probably get into the habit of making new branches even for that since I'm usually pretty good about cleaning up my own old branches. | 20:31 | ||
| by "my on-github repo" I meant my on-GH personal fork of the docs repo. That's what I use as the upstream origin of my desktop repo. | 20:32 | ||
|
21:08
arkiuat left
21:21
Voldenet left
21:40
arkiuat joined
21:45
arkiuat left
22:05
Voldenet joined
22:12
arkiuat joined
22:17
arkiuat left
|
|||
| [Coke] | tbrowder: you online? | 23:14 | |
| disbot8 | <arkiuat> thanks | 23:27 | |
| tbrowder | yeah, i'll just submit a new PR tomorrow, sorry about my ignorance | 23:29 | |