Geth doc: tbrowder++ created pull request #4750:
Add description of new Rakudo test 'exits-ok'		 00:16
tbrowder arg, i think i messed it up again... 00:23
[Coke] You should be able to just keep pushing on the same branch and the PR will automatically update. 00:32
Geth doc: coke++ created pull request #4751:
Start a PR		 00:41
[Coke] That is just a sample PR. I have a fork. I did a new branch, did one commit, opened a PR. 00:42
did another commit. Pushed it. it *immediately* shows up on the PR that was already opened.
and there was no message on the push about opening a new PR. 00:43
if you look at the PR, you can see where I marked the PR as draft - that was after the initial open of the PR. the commit right after that - that was just from me pushing to git@github.com:coke/doc.git on the coke/some-pr branch. 00:44
When I was getting my old fork clean, I did have to switch the main branch from master to main to track the repo. (it's been a while since I touched it) 01:26
tbrowder hm, the PR looks correct now and ready to merge. 03:08
[Coke] still has trailing whitespace 04:31
line 231 04:32
09:59 wayland76 joined, wayland left
tbrowder i don't see it on my host, i'll try to edit on github 11:51
[Coke] with the updated one, I can see it on "test L<C<exits-ok>|/type/Test#sub_exits-ok>. " at least. 14:30
what editor do you use for local edits? in vi, you can use slash space $ to find any spaces at the end of a line - not all whitespace, but the typical one. 14:31
tbrowder vi, i'll do that... 14:43
nada! 14:49
is it possible it's a non-breaking space? unicode has several kinds of "spaces" 14:55
i'll try another edit on github in a while... 14:57
it worked this time. it's weird i couldn't see the extra space locally 15:29
it's still failing on whitespace, but i'm not sure it's due to my code. i give up for now. 16:40
18:22 arkiuat joined
Geth doc/arkiuat-patch-1: c20b3d41e9 | (Eric Forste)++ (committed using GitHub Web editor) | doc/Language/control.rakudoc
control.rakudoc: bad link to #Closures section

a link plainly intended to direct to the #Closures section instead pointed to the #Blocks_and_lambdas section. Corrected.		 18:35
doc: arkiuat++ created pull request #4752:
control.rakudoc: bad link to #Closures section		 18:36
¦ doc: arkiuat self-assigned The whole explanation for the difference between block and closure is LTA github.com/Raku/doc/issues/3670 18:38
18:39 finanalyst joined 19:09 lizmat joined 19:10 Geth joined 19:13 arkiuat left 19:20 arkiuat joined 19:24 arkiuat left 19:41 arkiuat joined 19:46 arkiuat left 19:58 arkiuat joined 20:06 arkiuat left
[Coke] tbrowder: can you run the trailing whitespace test locally? 20:26
20:26 arkiuat joined 20:31 arkiuat left
tbrowder yes. just a moment 20:34
20:44 arkiuat joined
tbrowder what test should i use? there is no modified branch so the *modified.sh doesn’t work 20:46
make 20:47
disregard “make”… 20:48
i 20:50
i’m running “make test”…
[Coke] RAKULIB=. TEST_FILES="<name of file>" t/04-trailing-whitespace.rakutest 20:55
much faster
tbrowder ah, i forgot... 21:21
git br 21:29
[Coke] my local system's repo main and tb-exists-ok are not in proper synch with docs/main. i don't know how to fix it quickly. what i will do is make sure and save my code and then completely delete my local and remote doc tree and start over unless you have a better solution. 21:36
21:54 finanalyst left
[Coke] it's line 234 of grep -n '\s$' doc/Language/testing.rakudoc 22:40
"not in sync" ?
the extra whitespace is just before the preamble line you added. 22:41
and it's just a regular space
You only edited one file, even if you did your branch off an older commit, it still applies cleanly. 22:42
(which the PR tells you at the end after the failed test)

Powered by Cro and the Raku® Programming Language.

Please report any issues / comments / feature requests as an issue on App::Raku::Log.

Thank you!